-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Git spans changed from enum to string #32454
Conversation
WalkthroughWalkthroughThe changes aim to streamline Git operations and boost observability in the Appsmith application, enhancing code maintainability and monitoring for improved performance tracking. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/GitServiceCEImpl.java
Outdated
Show resolved
Hide resolved
app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/GitServiceCEImpl.java
Outdated
Show resolved
Hide resolved
app/server/appsmith-interfaces/src/main/java/com/appsmith/external/git/constants/GitSpans.java
Outdated
Show resolved
Hide resolved
Failed server tests
|
Failed server tests
|
import static com.appsmith.external.constants.spans.BaseSpan.APPSMITH_SPAN_PREFIX; | ||
import static com.appsmith.external.constants.spans.BaseSpan.GIT_SPAN_PREFIX; | ||
|
||
public class GitSpansCE { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, existing classes are singular, please converge nomenclature
public static final String FILE_SYSTEM_PUSH = APPSMITH_SPAN_PREFIX + GIT_SPAN_PREFIX + "file_system_push"; | ||
public static final String FILE_SYSTEM_FETCH_REMOTE = | ||
APPSMITH_SPAN_PREFIX + GIT_SPAN_PREFIX + "file_system_fetch_remote"; | ||
public static final String STATUS = APPSMITH_SPAN_PREFIX + GIT_SPAN_PREFIX + "status"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all of these compounds at API level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the one which doesn't have FILE_SYSTEM prefix
...r/appsmith-server/src/main/java/com/appsmith/server/applications/spans/ApplicationSpans.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nomenclature related comments.
Failed server tests
|
Description
Fixes
Issue URL
Automation
/ok-to-test tags="@tag.Git"
🔍 Cypress test results
Summary by CodeRabbit
Important
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8613398600
Commit:
60d265ab55b3373a73f48cc1fb6e3124027dd000
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉